mount whitelist of devices on insecure security mode #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
security-devices
branch
from
ffbe5b9 to
81fa647
Compare
| logrus.Debugf("failed to get next free loop device: %v", err) | ||
| } | ||
|
|
||
| for i := 0; i <= loopID+7; i++ { |
There was a problem hiding this comment.
Is there any specific reason for these 7 loop devices?
There was a problem hiding this comment.
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
security-devices
branch
from
81fa647 to
8f52339
Compare
thaJeztah
reviewed
Jan 31, 2020
|
@kunalkushwaha Did you test it? |
|
Tested. LGTM. |
AkihiroSuda
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes docker/buildx#220
Unlike
docker run --privilegedwe don't mount all the devices from host because that would give inconsistent environments for different hosts that we would like to avoid (and later solve with constraints). But we can mount a whitelist of devices that are always created by regular distros and commonly used. Permissions are granted to users to read/write all the devices, for the missing ones you just need tomknodthe device yourself.Devices currently created with
--security=insecure: